Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First-Tier contribution analysis tab #1046

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

First-Tier contribution analysis tab #1046

wants to merge 15 commits into from
+324 −6

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Sep 22, 2023 •
edited
Loading

New feature to implement contribution analysis for products.

thumbnail_image

TODOS;

  • Only start calculation on tab-open, same as with Sankey tab
  • Update wiki

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog
  • Link this PR to related issues.

@marc-vdm marc-vdm added the feature Issues/PRs related to a new feature label Sep 22, 2023
@marc-vdm marc-vdm added this to the 2.10 milestone Sep 22, 2023
@coveralls
Copy link

coveralls commented Sep 22, 2023 •
edited
Loading

Coverage Status

coverage: 53.782% (-0.4%) from 54.201%
when pulling d90dddc on marc-vdm:first_level_cont
into 1165399 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm mentioned this pull request Nov 8, 2023
Closed
@marc-vdm marc-vdm changed the base branch from master to v2.10.0 February 9, 2024 14:08
@marc-vdm marc-vdm changed the base branch from v2.10.0 to minor February 20, 2024 12:32
@marc-vdm
Merge branch 'master' into first_level_cont
86eccc5
@marc-vdm
Merge branch 'minor' into first_level_cont
889108f 
# Conflicts:
#	activity_browser/controllers/database.py
#	activity_browser/layouts/tabs/LCA_results_tabs.py
@marc-vdm
re-add product tab to Tabs tuple
5f66b0c
@marc-vdm marc-vdm changed the title New Product (first-level) contribution analysis tab First-Tier contribution analysis tab Apr 20, 2024
@marc-vdm marc-vdm removed this from the 2.10 milestone Jun 4, 2024
@marc-vdm marc-vdm mentioned this pull request Jun 28, 2024
Open
7 tasks
@marc-vdm marc-vdm changed the base branch from minor to main June 28, 2024 10:20
@marc-vdm marc-vdm added this to the 2.11.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

1st level contributions Show contributions of all activities/biosphere flows of production activity
2 participants
@marc-vdm @coveralls